[PATCH] D24639: [Sema] Warn when returning a lambda that captures a local variable by reference

Erik Pilkington via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Apr 3 12:53:25 PDT 2019


erik.pilkington added a comment.

In D24639#1453795 <https://reviews.llvm.org/D24639#1453795>, @bgianfo wrote:

> Is there a reason why this was never merged?
>  Has the functionality been folded in in some other revision?
>
> I saw a bug recently which would have been caught by exactly this, which would have been awesome.
>  How can we get this merged?


Just never got reviewed, then I must of got distracted with other things and stopped pinging. I think it's a useful diagnostic, so would be nice to have. As far as landing this, it just needs to be rebased and reviewed. If you (or anyone else) is interested in this, feel free to commandeer this revision. Otherwise I might come back to it later.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D24639/new/

https://reviews.llvm.org/D24639





More information about the cfe-commits mailing list