[PATCH] D59121: [analyzer] Fix macro names in diagnostics within bigger macros.

Csaba Dabis via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Mar 29 14:21:16 PDT 2019


Charusso added a comment.

In D59121#1448367 <https://reviews.llvm.org/D59121#1448367>, @NoQ wrote:

> On second thought, dunno. In the scan-build macro preview it wouldn't show you UINT32_MAX anyway. Maybe let's keep this behavior.
>
> Cleaned up the patch a little bit.


Somehow on the `Assuming ...` pieces we write out the macro name, and my little code did that too. We could obtain the value but I think your first intention is the correct behaviour. Why are you not using my working example?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59121/new/

https://reviews.llvm.org/D59121





More information about the cfe-commits mailing list