[PATCH] D53809: Fix invalid address space generation for clk_event_t

Alexey Sotkin via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Mar 29 04:40:14 PDT 2019


AlexeySotkin added inline comments.


================
Comment at: lib/CodeGen/CGBuiltin.cpp:3614
+      ClkEvent = ClkEvent->getType()->isIntegerTy()
+                   ? Builder.CreateBitOrPointerCast(ClkEvent, EventPtrTy)
+                   : Builder.CreatePointerCast(ClkEvent, EventPtrTy);
----------------
Anastasia wrote:
> It doesn't seem like we are testing the cast however?
Sorry, could you elaborate on your question/concern ?


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D53809/new/

https://reviews.llvm.org/D53809





More information about the cfe-commits mailing list