[PATCH] D59725: Additions to creduce script

Alexander Richardson via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Mar 29 02:51:23 PDT 2019


arichardson accepted this revision.
arichardson added a comment.
This revision is now accepted and ready to land.

LGTM once the tempfile is deleted.



================
Comment at: clang/utils/creduce-clang-crash.py:208
+    print("\nTrying to preprocess the source file...")
+    # use delete=False in case the tmpfile flag causes problems when copying
+    with tempfile.NamedTemporaryFile(delete=False) as tmpfile:
----------------
I believe we are currently not deleting this temporary file.
Can `delete=False` be removed since we are using `shutil.copy()` instead of a move?



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59725/new/

https://reviews.llvm.org/D59725





More information about the cfe-commits mailing list