[PATCH] D59900: [Sema] Fix a crash when nonnull checking

Artem Belevich via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 28 15:05:37 PDT 2019


tra added inline comments.


================
Comment at: clang/test/SemaTemplate/decltype.cpp:1
+// RUN: %clang_cc1 -std=c++11 -fsyntax-only -verify %s
+// no crash & no diag
----------------
Rakete1111 wrote:
> test/SemaCXX/nonnull.cpp would be a better place to put this test.
`test/SemaCXX/nonnull.cpp` tests `attribute((nonnull))`. Placing this test there would be... odd.

The test could use a more descriptive name, though. Just `decltype` is way too generic. `early-func-template-decltype`? Or PR-somthing-something, if there's a bug for this crasher.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59900/new/

https://reviews.llvm.org/D59900





More information about the cfe-commits mailing list