[PATCH] D59927: [clangd] Support UTF-32 (i.e. codepoint) offsets.

[Sam McCall via Phabricator via cfe-commits]

sammccall marked an inline comment as done.
sammccall added inline comments.


================
Comment at: unittests/clangd/SourceCodeTests.cpp:164
+                       llvm::Failed()); // out of range
+  // middle line
+  EXPECT_THAT_EXPECTED(positionToOffset(File, position(1, -1)),
----------------
ilya-biryukov wrote:
> small NIT: the `.` is missing at the end of the comment. Same for lots of comments in the file, I guess.
hmm, these are fragments rather than sentences (no caps, no trailing punctuation).
Are we not supposed to use those? There are some in the coding standards examples!


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59927/new/

https://reviews.llvm.org/D59927