[PATCH] D59670: [Sema] Fix an assert when a block captures a constexpr local

[John McCall via Phabricator via cfe-commits]

rjmccall added inline comments.


================
Comment at: clang/lib/Sema/SemaExpr.cpp:15692
+  MaybeODRUseExprSet LocalMaybeODRUseExprs;
+  std::swap(LocalMaybeODRUseExprs, MaybeODRUseExprs);
+
----------------
It looks like `SmallPtrSet`'s move constructor does actually guarantee to leave the source empty; you could probably just assert that.  But I don't think there's an algorithmic cost, so this is fine, too.

Please leave an assertion at the bottom of this function that the set is empty.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59670/new/

https://reviews.llvm.org/D59670