[PATCH] D59759: [clangd] Add .cu files to VSCode extension

[Ilya Biryukov via Phabricator via cfe-commits]

ilya-biryukov added a comment.

In D59759#1441402 <https://reviews.llvm.org/D59759#1441402>, @hokein wrote:

> Taking a closer look, it seems cuda is not supported by default in vscode :(
>
> vscode provides a way to add a new language in the extension, see https://code.visualstudio.com/api/references/contribution-points#contributes.languages, we may define the cuda language in our extension, but vscode also uses this configuration to do other stuff, like syntax highlight, it seems out of scope of our extension, and I'm not sure how would it work with other cuda extension (like vscode-cudacpp which implements the cuda language).


Agree, we shouldn't define it in our extensions. Actually, IMO the best place for it would be the VSCode code itself. Maybe someone interested in CUDA would pioneer it at some point this and send a PR to VSCode :-)

> I guess we might leave the patch as it is. clangd won't be started if vscode users only open `.cu` files; once the users open a c++ file, clangd starts, and clangd should also work for cuda files.

+1, as annoying as it is, this looks like the best option so far.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59759/new/

https://reviews.llvm.org/D59759