[PATCH] D58897: [ASTImporter] Make ODR error handling configurable

Endre Fülöp via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 25 04:11:28 PDT 2019


gamesh411 added inline comments.


================
Comment at: include/clang/AST/ASTStructuralEquivalence.h:81
         EqKind(EqKind), StrictTypeSpelling(StrictTypeSpelling),
-        ErrorOnTagTypeMismatch(ErrorOnTagTypeMismatch), Complain(Complain) {}
+        Complain(Complain), ErrorOnTagTypeMismatch(ErrorOnTagTypeMismatch) {}
 
----------------
a_sidorin wrote:
> I see the argument order change but I don't see any callers changed. Do we really need this order change?
Strictly speaking, there is no need for this change, the constructor param order does not match the initialization, but that is just a nit. I have updated the diff. Cheers :)


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58897/new/

https://reviews.llvm.org/D58897





More information about the cfe-commits mailing list