[PATCH] D57943: [clangd] **Prototype**: clang-tidy-based tweaks

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 25 02:57:55 PDT 2019


ilya-biryukov added a comment.
Herald added a subscriber: jdoerfert.

Another alternative we could consider would be collecting these fixes when producing the clang-tidy diagnostics.
We won't show the diagnostics to the users if they have the check disabled, but we would stash the ranges and the textual fixes somewhere.
I.e. I'm suggesting to reuse something closer to the mechanism of diagnostics fix-its, not the code tweak interfaces.

The advantages are:

1. keeping clang-tidy integration in one place,
2. no extra runs of ast matchers, all tidy checks will run during diagnostics.

WDYT?


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57943/new/

https://reviews.llvm.org/D57943





More information about the cfe-commits mailing list