[PATCH] D59466: [clang-tidy] openmp-exception-escape - a new check

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Mar 22 12:16:53 PDT 2019


aaron.ballman accepted this revision.
aaron.ballman added a comment.

Aside from a docs nit, LGTM!



================
Comment at: docs/clang-tidy/checks/openmp-exception-escape.rst:13
+structured block. If an exception is not caught in the same structured block
+it was thrown in, the behaviour is undefined, the program will likely terminate.
+
----------------
I would remove the bit about the program being likely to terminate -- we have no idea what it will do if it hits UB, so better to just let those words stand on their own.


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59466/new/

https://reviews.llvm.org/D59466





More information about the cfe-commits mailing list