r356700 - [clang][OpenMP] Fix another test when using libgomp.

Roman Lebedev via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 21 12:22:01 PDT 2019


Thank you for the fix.

I remembered of the yesterday's fix, but either forgot about it here,
or incorrectly recalled this code would be relying on the yesterday's code
(as in, no fix would be needed.)

Roman.

On Thu, Mar 21, 2019 at 10:11 PM Jordan Rupprecht via cfe-commits
<cfe-commits at lists.llvm.org> wrote:
>
> Author: rupprecht
> Date: Thu Mar 21 12:13:22 2019
> New Revision: 356700
>
> URL: http://llvm.org/viewvc/llvm-project?rev=356700&view=rev
> Log:
> [clang][OpenMP] Fix another test when using libgomp.
>
> Similarly to r356614, -fopenmp=libomp needs to be used for some omp-related AST matching.
>
> Modified:
>     cfe/trunk/unittests/ASTMatchers/ASTMatchersTest.h
>
> Modified: cfe/trunk/unittests/ASTMatchers/ASTMatchersTest.h
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/unittests/ASTMatchers/ASTMatchersTest.h?rev=356700&r1=356699&r2=356700&view=diff
> ==============================================================================
> --- cfe/trunk/unittests/ASTMatchers/ASTMatchersTest.h (original)
> +++ cfe/trunk/unittests/ASTMatchers/ASTMatchersTest.h Thu Mar 21 12:13:22 2019
> @@ -237,13 +237,13 @@ testing::AssertionResult notMatchesWithC
>  template <typename T>
>  testing::AssertionResult matchesWithOpenMP(const std::string &Code,
>                                             const T &AMatcher) {
> -  return matchesConditionally(Code, AMatcher, true, "-fopenmp");
> +  return matchesConditionally(Code, AMatcher, true, "-fopenmp=libomp");
>  }
>
>  template <typename T>
>  testing::AssertionResult notMatchesWithOpenMP(const std::string &Code,
>                                                const T &AMatcher) {
> -  return matchesConditionally(Code, AMatcher, false, "-fopenmp");
> +  return matchesConditionally(Code, AMatcher, false, "-fopenmp=libomp");
>  }
>
>  template <typename T>
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


More information about the cfe-commits mailing list