[PATCH] D59647: [CUDA][HIP] Warn shared var initialization

Justin Lebar via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 21 11:19:23 PDT 2019


jlebar added a comment.

> By default it is still treated as error, therefore no behavior change of clang.

Oh, I see, you already did what I'd suggested.  :)

That's better.  I think this needs to be made *much scarier* though.  "Maybe race condition" doesn't capture the danger here -- you can very quickly get UB.

Maybe Richard has thoughts on whether we should allow broken things like this.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59647/new/

https://reviews.llvm.org/D59647





More information about the cfe-commits mailing list