[PATCH] D59639: [clangd] Print template arguments helper

Eric Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 21 10:47:59 PDT 2019


ioeric added inline comments.


================
Comment at: clang/lib/AST/TypePrinter.cpp:1640
+
+static void printArgument(const TemplateArgumentLoc &A,
+                          const PrintingPolicy &PP, llvm::raw_ostream &OS) {
----------------
It's unclear to me what the new behavior is with changes in this file. Could you add comment?

It might make sense to split the clang change into a separate patch and get folks who are more familiar to take a look.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59639/new/

https://reviews.llvm.org/D59639





More information about the cfe-commits mailing list