[PATCH] D59566: [X86] Correct the value of MaxAtomicInlineWidth for pre-586 cpus

Craig Topper via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 21 00:24:55 PDT 2019


craig.topper updated this revision to Diff 191643.
craig.topper added a comment.
Herald added subscribers: cfe-commits, jdoerfert.
Herald added a project: clang.

Rewrite to use a "cx8" feature flag that is set for all i586 and greater CPUs as well as generic. This assumes generic is never passed in a run of clang through the driver. And anyone using -cc1 directly is unlikely to be using an i486.

I've updated the init.c test to use i486 for the NETBSD test since I think that's what the driver defaults to. This is used as the test for i486. I've added command lines with -malign-double set which should force 64-bit types to have 64 bit alignment instead of the default 32 bit alignment. This is needed to get the LLONG_LOCK_FREE macro to be 2 on i586 and greater.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59566/new/

https://reviews.llvm.org/D59566

Files:
  lib/Basic/Targets/X86.cpp
  lib/Basic/Targets/X86.h
  test/CodeGen/attr-cpuspecific.c
  test/CodeGen/attr-target-x86-mmx.c
  test/CodeGen/attr-target-x86.c
  test/CodeGen/attr-target-x87-softfp.c
  test/Preprocessor/init.c

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D59566.191643.patch
Type: text/x-patch
Size: 13909 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20190321/bbddbb56/attachment-0001.bin>


More information about the cfe-commits mailing list