[PATCH] D59609: [clang][OpenMP] Fix build when using libgomp

Jordan Rupprecht via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 20 14:03:38 PDT 2019


rupprecht added a comment.

In D59609#1436975 <https://reviews.llvm.org/D59609#1436975>, @lebedev.ri wrote:

> Interesting.
>  What happens if libomp is not being built?
>  What happens if libomp is not present?


I'm far from an omp expert (only running across this because some tests failed), but I would guess both those cases to break.

But this is broken anyway when libomp isn't being used. So the set of broken cases is going from (people that don't use libomp) to (people that don't have libomp) which I think is a much smaller subset.

> Or more generally, why does it even matter whether there is runtime or not, this only does paring+sema, no codegen/execution.

I'm very surprised myself. Hence my question "has something gone wrong" on D59214 <https://reviews.llvm.org/D59214>. Hopefully this fix/hack can be reverted once that's figured out.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59609/new/

https://reviews.llvm.org/D59609





More information about the cfe-commits mailing list