[PATCH] D58531: [clang] Specify type of pthread_create builtin

Stephen Hines via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 20 08:43:39 PDT 2019


srhines added inline comments.


================
Comment at: clang/lib/AST/ASTContext.cpp:9574
 
-  assert(!RequiresICE && "Result of intrinsic cannot be required to be an ICE");
+  assert(!RequiresICE && "Result of function cannot be required to be an ICE");
 
----------------
I would just remove "of function" here, since it isn't correct when you are not decoding a function, and the two words don't make that much more meaningful even in the original case, so I don't think it justifies something like "of intrinsic/function".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58531/new/

https://reviews.llvm.org/D58531





More information about the cfe-commits mailing list