[PATCH] D57896: Variable names rule

Csaba Dabis via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 19 11:59:38 PDT 2019


Charusso added a comment.

In D57896#1435245 <https://reviews.llvm.org/D57896#1435245>, @lattner wrote:

> FWIW, my suggestion is *not* to expand names like DRE to decl_ref_expr, I agree that doesn't add clarity to the code.  Two possibilities: "dre", or "decl" which is what I would write today.


I totally agree with you, wherever I can I write that out for clarification. Please note that in my example there is two `Expr` and that is why I pointed out we need acronyms so we cannot really use `expr` and acronyms usually capital, that is why we went back to the default CamelCase standard. It was a little brainstorming and ping for you guys because I believe you would put those polls out and create a better code-base.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57896/new/

https://reviews.llvm.org/D57896





More information about the cfe-commits mailing list