[PATCH] D59463: [ASTMatchers][OpenMP] OpenMP Structured-block-related matchers

Dmitri Gribenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 18 03:33:46 PDT 2019


gribozavr added inline comments.


================
Comment at: include/clang/ASTMatchers/ASTMatchers.h:6389
 
+/// Given OpenMP directive, matches if it is an OpenMP standalone directive,
+/// i.e. an executable directive with no structured block.
----------------
"Matches standalone OpenMP directives, i.e., directives that can't have a structured block."


================
Comment at: include/clang/ASTMatchers/ASTMatchers.h:6400
+///   #pragma omp taskyield  // <- match, is standalone
+/// \endcode
+AST_MATCHER(OMPExecutableDirective, isStandaloneDirective) {
----------------
Please follow the existing comment style. Either:

```
Given

\code
<code snippet>
\endcode

<matcher expression> matches "<code snippet>".
```

or

```
Example: <matcher expression> matches "<code snippet>" in 

\code
<code snippet>
\endcode
For example:

Given

 \code
   #pragma omp parallel default(none)
   #pragma omp parallel default(shared)
   #pragma omp parallel
 \endcode

``ompDefaultClause()`` matches ``default(none)` and ``default(shared)``.
```

Similarly for other comments in this patch.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59463/new/

https://reviews.llvm.org/D59463





More information about the cfe-commits mailing list