[PATCH] D59350: [clangd] Build Dex index after loading all shards in BackgroundIndex.

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 14 02:34:23 PDT 2019


hokein created this revision.
hokein added a reviewer: kadircet.
Herald added subscribers: arphaman, jkorous, MaskRay, ioeric, ilya-biryukov.
Herald added a project: clang.

Currently after loadding all shards, we use MemIndex which has poor query
performance, we should use Dex.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D59350

Files:
  clangd/index/Background.cpp


Index: clangd/index/Background.cpp
===================================================================
--- clangd/index/Background.cpp
+++ clangd/index/Background.cpp
@@ -374,7 +374,9 @@
     // extra index build.
     reset(
         IndexedSymbols.buildIndex(IndexType::Heavy, DuplicateHandling::Merge));
-    log("BackgroundIndex: rebuilt symbol index.");
+    log("BackgroundIndex: rebuilt symbol index with estimated memory {0} "
+        "bytes.",
+        estimateMemoryUsage());
   }
 }
 
@@ -603,8 +605,10 @@
     }
   }
   vlog("Loaded all shards");
-  reset(IndexedSymbols.buildIndex(IndexType::Light, DuplicateHandling::Merge));
-
+  reset(IndexedSymbols.buildIndex(IndexType::Heavy, DuplicateHandling::Merge));
+  vlog("BackgroundIndex: built symbol index with estimated memory {0} "
+        "bytes.",
+        estimateMemoryUsage());
   return NeedsReIndexing;
 }
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D59350.190578.patch
Type: text/x-patch
Size: 881 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20190314/2c0df84e/attachment.bin>


More information about the cfe-commits mailing list