[PATCH] D59254: [RFC] Implementation of Clang randstruct

[Tim Pugh via Phabricator via cfe-commits]

timpugh added inline comments.


================
Comment at: clang/include/clang/AST/RecordFieldReorganizer.h:54
+  std::seed_seq Seq;
+  std::default_random_engine rng;
+};
----------------
connorkuehl wrote:
> pcc wrote:
> > I don't think we can use `default_random_engine` for this because the behaviour would need to be consistent between C++ standard library implementations, and the behaviour of `default_random_engine` is implementation defined. Similarly, I don't think that we can use `std::shuffle` (see note in https://en.cppreference.com/w/cpp/algorithm/random_shuffle ).
> Sure thing, we'll begin investigating alternatives.
@pcc  if we were to swap `default_random_engine` for a pre-defined random generator such as `mt19937_64` would this suffice? It is included in the random number library.

https://en.cppreference.com/w/cpp/numeric/random


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59254/new/

https://reviews.llvm.org/D59254