[PATCH] D59279: [Analyzer] Checker for non-determinism caused by iteration of unordered container of pointers

Wed Mar 13 12:02:12 PDT 2019

Szelethus added a comment.

Could you please add a commit that changes the top of the file on your previous commit? Feel free to do that without review (I can't commit it myself atm).

In D59279#1427803 <https://reviews.llvm.org/D59279#1427803>, @mgrang wrote:

> Also, what is the difference between these two: https://clang.llvm.org/docs/analyzer/checkers.html, https://clang-analyzer.llvm.org/available_checks.html. It seems they document similar stuff. Should we add the doc for each new checker in both of these?

Umm, yea, we're in the middle of moving from the HTML format to the new sphinx format, so I think it's fine to ignore the latter, and only extend `docs/analyzer/checkers.rst`. Since the moving is a lot of manual labor, we haven't gotten around getting rid of it entirely just yet. But of course, it's welcome

In D59279#1427798 <https://reviews.llvm.org/D59279#1427798>, @mgrang wrote:

> > The obvious question, why not implement this in clang-tidy?
>
> Going forward I would like to make these non-determinism checks more precise by reasoning about what happens inside the loop, for example. I am not sure if clang-tidy has support for such deeper reasoning. I thought clang-tidy is more of a pattern matcher?

Yup, I'm sold on that.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59279/new/

https://reviews.llvm.org/D59279