[PATCH] D59287: [X86] Only define __GCC_HAVE_SYNC_COMPARE_AND_SWAP_16 in 64-bit mode.

JF Bastien via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 13 10:08:11 PDT 2019


jfb added a comment.

In D59287#1427654 <https://reviews.llvm.org/D59287#1427654>, @craig.topper wrote:

> Most if not all of the test cases in test/CodeGen/X86/atomic128.ll fail with a fatal error if you run it in 32-bit mode with -mattr=+cx16  Looks like the backend is also bad at checking 64 bit mode.


So you're saying we're consistent, but in a bad way? It seems like an i386 target just shouldn't be allowed to set cx16, no?


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59287/new/

https://reviews.llvm.org/D59287





More information about the cfe-commits mailing list