[PATCH] D58749: [index-while-building] IndexRecordHasher
Kadir Cetinkaya via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Mar 12 13:39:19 PDT 2019
kadircet added a comment.
> I basically didn't really like the idea of testing against hard-coded hash values in unittests as I consider it to be an implementation detail. I was thinking about integration tests that would work around this by both writing index and reading index and writing assertions against that data. What do you think?
Instead of testing against hardcoded values maybe you can test for difference? Making sure hashes differ or stays same when appropriate changes are done to the contents?
CHANGES SINCE LAST ACTION
More information about the cfe-commits