[PATCH] D57922: [analyzer] Insert checker options into AnalyzerOption::ConfigTable

Balogh, Ádám via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 12 07:19:24 PDT 2019


baloghadamsoftware added inline comments.


================
Comment at: lib/StaticAnalyzer/Frontend/CheckerRegistry.cpp:332
+  AnOpts.Config.insert({(Twine() + CheckerFullName + ":" + OptionName).str(),
+                        DefaultValStr});
 }
----------------
`Twine(CheckerFullName) + ":" + OptionName`. However, since the constructor `Twine(const StringRef &Str)` is implicit, `CheckerFullName + ":" + OptionName` results the same and is more readable.


================
Comment at: lib/StaticAnalyzer/Frontend/CheckerRegistry.cpp:354
+  AnOpts.Config.insert({(Twine() + FullName + ":" + OptionName).str(),
+                        DefaultValStr});
 }
----------------
Same as above.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57922/new/

https://reviews.llvm.org/D57922





More information about the cfe-commits mailing list