[PATCH] D31739: Add markup for libc++ dylib availability

Louis Dionne via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 11 09:42:13 PDT 2019


ldionne added inline comments.


================
Comment at: libcxx/trunk/test/std/thread/thread.mutex/thread.lock/thread.lock.shared/lit.local.cfg:1
+if 'availability' in config.available_features:
+    config.unsupported = True
----------------
mehdi_amini wrote:
> thakis wrote:
> > Did you mean `not in` here? I don't understand why we want to skip this tests is availability annotations are present.
> Thanks for looking into this, unfortunately I don't remember the context from 2 years ago.  It may have been a typo indeed.
> 
> @ldionne and @Bigcheese  may be able to help here!
Hmm, I wasn't aware of this. I guess this is because `shared_***` used to be marked as unconditionally unavailable, but that changed. I'll figure out when we can enable these tests.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D31739/new/

https://reviews.llvm.org/D31739





More information about the cfe-commits mailing list