[PATCH] D59094: [ARM] Fix bug 39982 - pcs("aapcs-vfp") is not consistent
Eli Friedman via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Mar 7 11:13:28 PST 2019
efriedma added a comment.
It looks like every call to getABIKind() is doing the wrong thing; I'm worried that's going to lead to some sort of subtle miscompile without some sort of centralized fix to compute the correct calling convention for every place that checks it. Not sure how to write a testcase off the top of my head... have you tried homogeneous aggregates with more than two elements?
================
Comment at: clang/test/CodeGenCXX/arm-pcs.cpp:4
+
+// RUN: %clang -mfloat-abi=hard --target=armv7-unknown-linux-gnueabi -O3 -S -o - %s | FileCheck %s -check-prefixes=HARD_INSTRs,CHECK
+// RUN: %clang -mfloat-abi=softfp --target=armv7-unknown-linux-gnueabi -O3 -S -o - %s | FileCheck %s -check-prefixes=HARD_INSTRs,CHECK
----------------
This test needs "// REQUIRES: arm-registered-target" so it's automatically disabled if the ARM target isn't available.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59094/new/
https://reviews.llvm.org/D59094
More information about the cfe-commits
mailing list