[PATCH] D59083: [clangd] Store explicit template specializations in index for code navigation purposes

Eric Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 7 03:33:32 PST 2019


ioeric added a comment.

> We need that information for providing better code navigation support, like find references, children/base classes etc.

It's not trivial how they make code navigation better. Can you explain and provide examples in the summary? Thanks!



================
Comment at: clangd/CodeComplete.cpp:1613
   };
+  // We index explicit template specializations merely for code navigation
+  // support.
----------------
nit: the context here is code completion. Maybe explain why they are not interesting for completion rather than why we index them?


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59083/new/

https://reviews.llvm.org/D59083





More information about the cfe-commits mailing list