[PATCH] D59086: [clangd] Adjust compile commands to be applicable for tooling

Kadir Cetinkaya via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 7 03:26:21 PST 2019


kadircet created this revision.
kadircet added reviewers: gribozavr, hokein.
Herald added subscribers: cfe-commits, jdoerfert, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov.
Herald added a project: clang.

As can be seen in https://github.com/llvm-mirror/clang/blob/master/lib/Tooling/Tooling.cpp#L385
clang tool invocations adjust commands normally like this. In clangd we have
different code paths for invoking a frontend action(preamble builds, ast builds,
background index, clangd-indexer) they all work on the same GlobalCompilationDatabase
abstraction, but later on are subject to different modifications.

This patch makes sure all of the clangd actions make use of the same compile
commands before invocation.

Enables background-index to work on chromium codebase(since they had dependency
file output in their compile commands).


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D59086

Files:
  clangd/GlobalCompilationDatabase.cpp
  clangd/GlobalCompilationDatabase.h
  unittests/clangd/GlobalCompilationDatabaseTests.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D59086.189681.patch
Type: text/x-patch
Size: 5369 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20190307/16b2315e/attachment-0001.bin>


More information about the cfe-commits mailing list