[PATCH] D39050: Add index-while-building support to Clang

Jan Korous via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 6 10:59:16 PST 2019


jkorous added a comment.

I'll address comments for this patch in the new set of patches.

@gribozavr I haven't put up this part of code for the new round of review yet. I will keep this on mind.

@mgrang This already landed in edbbe470f66 <https://reviews.llvm.org/rGedbbe470f66dec90e336e7c2f2f34ddca070ac22> as `clang/lib/Index/FileIndexRecord.cpp` but luckily the implementation isn't using `sort()` at all. Thanks for pointing this out anyway!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D39050/new/

https://reviews.llvm.org/D39050





More information about the cfe-commits mailing list