[PATCH] D57965: Clean up ObjCPropertyDecl printing
David Goldman via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Mar 4 13:18:04 PST 2019
dgoldman added a comment.
In D57965#1417361 <https://reviews.llvm.org/D57965#1417361>, @jkorous wrote:
> Hi David,
> I am just wondering - while you're here would you mind adding couple more tests? It would be great to have a test for each attribute.
>
> Also, what do you think about Ben's suggestion? I think it would be nice to be consistent with the style Objective-C documentation uses:
> https://developer.apple.com/library/archive/documentation/Cocoa/Conceptual/ProgrammingWithObjectiveC/EncapsulatingData/EncapsulatingData.html
Sure, I can add a few more tests.
Hmm, I've seen it more often the other way around; to be honest I think the docs that you've linked to are outdated. See https://developer.apple.com/documentation/uikit/uiapplication/1622975-sharedapplication?language=objc for an example of what I've seen.
I do think that it would be nice to have `X *prop` instead of `X * prop` though, let me try adding that.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57965/new/
https://reviews.llvm.org/D57965
More information about the cfe-commits
mailing list