[PATCH] D58751: Order File Instrumentation: add clang support for -forder-file-instrumentation

Mon Mar 4 10:06:37 PST 2019

modocache accepted this revision.
modocache added a comment.
This revision is now accepted and ready to land.

Looks good, thanks for adding a driver option for this!

================
Comment at: include/clang/Driver/Options.td:774
+    Group<f_Group>, Flags<[CoreOption]>,
+    HelpText<"Generate instrumented code to collect order file into default.profraw file (overridden by '=' form of option or LLVM_PROFILE_FILE env var)">;

----------------
Would it make sense to add documentation to the Clang User's Manual for this option? Some other profiling options are mentioned there, but not all.

Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58751/new/

https://reviews.llvm.org/D58751