[PATCH] D58885: Variable auto-init: split out small arrays

Alexander Potapenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 4 09:43:35 PST 2019


glider accepted this revision.
glider added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lib/CodeGen/CGDecl.cpp:1206
+  bool canDoSingleStore = Ty->isIntOrIntVectorTy() ||
+                          Ty->isPtrOrPtrVectorTy() || Ty->isFPOrFPVectorTy();
+  if (canDoSingleStore) {
----------------
jfb wrote:
> glider wrote:
> > Is the second expression being moved to line 1206 a result of clang-format? Otherwise it'll migrate back at some point.
> Yes, the slightly longer name pushes it past 80 columns, and I just auto-format stuff before uploading.
> 
> I can do this change separately, I just noticed that the name I originally used was now misleading because vectors aren't scalars :)
Up to you, this doesn't matter IMO :)


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58885/new/

https://reviews.llvm.org/D58885





More information about the cfe-commits mailing list