[PATCH] D58797: [Sema] Add some compile time _FORTIFY_SOURCE diagnostics
George Burgess IV via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Mar 1 11:40:39 PST 2019
george.burgess.iv added a comment.
Thanks for working on this!
I hope to take an in-depth look at this patch next week (if someone else doesn't beat me to it...), but wanted to note that I think enabling clang to emit these warnings on its own is a good thing. `diagnose_if` is great for potentially more targeted/implementation-defined things that standard libraries want to diagnose, but IMO clang should be able to catch trivially broken code like this regardless of the stdlib it's building against.
CHANGES SINCE LAST ACTION
More information about the cfe-commits