[PATCH] D58742: [WebAssembly] Remove uses of ThreadModel

Sam Clegg via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 28 11:13:05 PST 2019

sbc100 added a comment.

In D58742#1413979 <https://reviews.llvm.org/D58742#1413979>, @sunfish wrote:

> Wasm gives users reasons to want -mthread-model single that other architectures don't, even when -matomics is enabled by default.
> When shared memory is used, wasm requires modules to declare a max memory size, which is a burden on applications that want to use dynamic amounts of memory. Wasm is more sensitive to code size than most other architectures. And, interoperating with single-threaded JS is easier from single-threaded wasm (JS has access to SharedArrayBuffer and atomics, but not all JS wants to use that).

Yes, but I don't see how that is related to this change.   I don't think there is a plan to make `-matomics` the default, and even if we did users would be free to disable it.

My understanding is that the default for clang and llvm and lld for the foreseeable will be to target single threaded mode, with non-shared-memory.   This CL doesn't change that.

  rLLD LLVM Linker



More information about the cfe-commits mailing list