[PATCH] D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC.

pierre gousseau via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 28 07:50:59 PST 2019

pgousseau marked an inline comment as done.
pgousseau added inline comments.

Comment at: include/clang/Basic/Sanitizers.h:29
+class hash_code;
riccibruno wrote:
> What ? You are forward-declaring `hash_code` here and using it as a value a few lines later. Just include `llvm/ADT/Hashing.h`.
Thanks for reviewing!
I am happy to include `Hashing.h` but I thought it was generally frown upon to add includes if avoidable?
`hash_code` is only used in the return type of the `hash_value()` declaration here no?
I saw StringRef.h or APInt.h also forward declare `hash_code`.
Thanks again for reviewing and sorry for the many iterations.



More information about the cfe-commits mailing list