[PATCH] D57898: CodeGen: Fix PR40605 by splitting constant struct initializers

Alexander Potapenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 28 02:48:37 PST 2019


glider added inline comments.


================
Comment at: clang/test/CodeGenCXX/auto-var-init.cpp:130
+// PATTERN-NOT-O1: @__const.test_bool4_custom.custom
+// ZERO-NOT-O1: @__const.test_bool4_custom.custom
+
----------------
jfb wrote:
> `-NOT` is in the wrong place above.
Hm, I wonder if lit could automatically check that all the patterns in the file are used in RUN lines.
(Probably no, it's hard to tell if an all-caps word is a pattern or just a comment)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57898/new/

https://reviews.llvm.org/D57898





More information about the cfe-commits mailing list