[PATCH] D58666: [OpenCL] Undefine cl_intel_planar_yuv extension
Anastasia Stulova via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Feb 28 02:39:06 PST 2019
Anastasia added inline comments.
Comment at: test/SemaOpenCL/extension-begin.cl:26
> Anastasia wrote:
> > sidorovd wrote:
> > > Anastasia wrote:
> > > > Can we also test that macro `my_ext` is not defined here but defined above?
> > > >
> > > > It seems we are not testing anything like this...
> > > #pragma OPENCL EXTENSION my_ext : begin doesn't define an appropriate macro. And so cl-ext=+my_ext.
> > But don't you need to expose the definition of it?
> Certainly I need, but now the only proper way to do so is by adding an extension via adding it in OpenCLExtensions.def. Previously we decided to avoid adding an extension directly into clang, so with a new approach I'd prefer not to add a definition of the macro in the header but define it somewhere else, otherwise the macro becomes defined where it's not supposed to be (even for ARM and AMD =) ).
However, my understanding is that you should define the macro when you define the extension itself.
#pragma OPENCL EXTENSION my_ext : begin
#pragma OPENCL EXTENSION my_ext : end
does it not work for you?
CHANGES SINCE LAST ACTION
More information about the cfe-commits