[PATCH] D56943: [clang-format][NFC] Allow getLLVMStyle() to take a language

Jordan Rupprecht via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Feb 27 11:22:21 PST 2019

rupprecht added inline comments.

Comment at: clang/lib/Format/ContinuationIndenter.cpp:193
                               RawStringFormat.Language, &PredefinedStyle)) {
-        PredefinedStyle = getLLVMStyle();
+        PredefinedStyle = getLLVMStyle(FormatStyle::LK_Cpp);
         PredefinedStyle.Language = RawStringFormat.Language;
MyDeveloperDay wrote:
> if you've set up a default argument of LK_Cpp do you need to keep supplying it? if your going to supply it everywhere don't make it a default argument or vice versa
> This might make a much smaller patch, a little more digestable and all the tests can remain as they are.
My goal was to fix all the in-tree callers but leave it as an optional arg (at least initially) so as to not break out of tree callers. I reduced it to what I actually need for this patch.

  rG LLVM Github Monorepo



More information about the cfe-commits mailing list