[PATCH] D58236: Make address space conversions a bit stricter.

Bevin Hansson via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Feb 27 02:19:25 PST 2019

ebevhan marked an inline comment as done.
ebevhan added inline comments.

Comment at: test/SemaOpenCL/address-spaces.cl:87
+  // FIXME: This doesn't seem right. This should be an error, not a warning.
+  __local int * __global * __private * lll;
Anastasia wrote:
> Are we sure it has to be an error? May be we can change this wording to something like - unknown behavior that needs clarifying? Some similar text to your comment in the code.
Well... If `__private int **` to `__generic int **` is an error but `__private int ***` to `__generic int **` isn't, that seems a bit odd to me...



More information about the cfe-commits mailing list