[PATCH] D58504: [OpenCL][8.0.0 Release] Notes for OpenCL

Mon Feb 25 07:52:47 PST 2019

hans added inline comments.

================
Comment at: docs/ReleaseNotes.rst:228

-OpenCL C Language Changes in Clang
+OpenCL Language Changes in Clang
 ----------------------------------
----------------
Anastasia wrote:
> Anastasia wrote:
> > AlexeySotkin wrote:
> > > AlexeySotkin wrote:
> > > > Why the "C" is removed ?
> > > Should we call the section like: "OpenCL Support in Clang"?
> > I would like to leave "Changes" in as it described the difference in this release. And I think "Language" should stay to be more precise that this doesn't cover libraries or runtime.
> > 
> > So I was think of either:
> > `OpenCL Kernel Language Change in Clang`
> >  or
> > `'OpenCL C/C++ Language Changes in Clang'`
> > 
> > I am a bit worried about the last one since it might link to the OpenCL C++ spec... even though it was used in the past release notes... but now that the direction has been changed I am not sure. Any opinion?
> We might need to finalize this quickly. @hans when is the last day to commit this to the release branch?
Within a day or two would be good.

But it looks like it got accepted now. Will you commit to the branch, or would you like me to do it for you?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58504/new/

https://reviews.llvm.org/D58504