[PATCH] D58612: Use std::atomic<> for static counters.
Ilya Biryukov via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Feb 25 05:59:45 PST 2019
ilya-biryukov added a comment.
In D58612#1408839 <https://reviews.llvm.org/D58612#1408839>, @riccibruno wrote:
> I don't know how hard it would be to do this, but I would like to argue that this should be done even if it require some refactoring. These static variables used for stats are kind of ugly imho; they conceptually belong to the AST context.
I agree, OTOH if refactoring would take more time than one can spare, moving them to atomics is better than what we have now.
For example, AFAIK that's the only thing that keeps clang from being tsan-clean.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the cfe-commits