[PATCH] D58541: [CodeComplete] Propagate preferred type for function arguments in more cases

[Kadir Cetinkaya via Phabricator via cfe-commits]

kadircet added inline comments.
Herald added a subscriber: Charusso.


================
Comment at: clang/include/clang/Sema/Sema.h:294
+  /// function_ref, clients should make sure all calls to get() with the same
+  /// location happen while function_ref is alive.
+  void enterFunctionArgument(SourceLocation Tok,
----------------
Is it only to avoid copy costs?


================
Comment at: clang/lib/Parse/ParseDeclCXX.cpp:3490
-          CalledSignatureHelp = true;
-          Actions.CodeCompleteExpression(getCurScope(), PreferredType);
         })) {
----------------
IIUC, deleting this call is safe, since it is going to be called in `ParseAssignmentExpression`. Could you add a comment stating that?(same for other deleted call sites of this function.)


================
Comment at: clang/unittests/Sema/CodeCompleteTest.cpp:457
+    void test() {
+      foo(^(^(^(^vector().^data()))));
+      bar(^(^(^(^vector().^data()))));
----------------
Can you also try in the middle of an identifier, like `vec^tor()`


================
Comment at: clang/unittests/Sema/CodeCompleteTest.cpp:458
+      foo(^(^(^(^vector().^data()))));
+      bar(^(^(^(^vector().^data()))));
+    }
----------------
maybe add a test for second parameter as well?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58541/new/

https://reviews.llvm.org/D58541