[PATCH] D58035: [clang/DIVar] Emit flag for params that have unchanged values

Bruno Ricci via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Feb 22 04:04:34 PST 2019


riccibruno added a comment.

I am wondering about the semantics of this bit. I don't think that you can know for sure within clang whether a variable has been modified. The best you can do is know for sure that some variable has been modified, but I don't think you can prove that it has not been modified.

Consequently I am wondering if you should change the name of this flag to something like `IsArgumentKnownToBeModified`.

Orthogonal to this you need to also add tests for templates.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58035/new/

https://reviews.llvm.org/D58035





More information about the cfe-commits mailing list