[PATCH] D57108: [clang-tidy] diagnose possibiltiy to add 'noexcept' in modernize-use-noexcept

Balogh, Ádám via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Feb 20 03:50:17 PST 2019


baloghadamsoftware added a comment.

Great! However, I would rename the test files: `modernize-use-noexcept-opt.cpp` is inaccurate since there are multiple options, it could be e.g. `modernize-use-noexcept-dont-use-noexcept-false.cpp`. `modernize-use-noexcept-new-noexcept.cpp` is a bit misleading because of the `new` which is a valid C++ keyword. `modernize-use-noexcept-add-missing-noexcept.cpp` sounds better for me.


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57108/new/

https://reviews.llvm.org/D57108





More information about the cfe-commits mailing list