[PATCH] D58074: [OpenMP 5.0] Parsing/sema support for map clause with mapper modifier

[Lingda Li via Phabricator via cfe-commits]

lildmh added a reviewer: kkwli0.
lildmh marked 4 inline comments as done.
lildmh added inline comments.


================
Comment at: lib/Parse/ParseOpenMP.cpp:2144
+        parseMapType(*this, Data);
     }
     if (Data.MapType == OMPC_MAP_unknown) {
----------------
kkwli0 wrote:
> Although it is an error situation, will we have different behavior?
> 
> ```
> ... map(xclose, to: x)
> ```
> 
> Previously, it always parses both modifier and type.  After the change, the call of `parseMapType` is skipped.  If it `OMPC_MAP_unknown`, `IsMapTypeImplicit` is set.
Hi Kelvin,

Thanks a lot for the review! It will not change the behavior of parsing modifiers other than mapper. `parseMapTypeModifiers` will only return true when it finds a invalid mapper for now.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58074/new/

https://reviews.llvm.org/D58074