[PATCH] D58069: [Sema] Mark GNU compound literal array init as an rvalue.

Eli Friedman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Feb 11 14:48:32 PST 2019


efriedma marked 2 inline comments as done.
efriedma added inline comments.


================
Comment at: lib/Sema/SemaInit.cpp:172-173
+      E = PE->getSubExpr();
+    else if (UnaryOperator *UO = dyn_cast<UnaryOperator>(E))
+      E = UO->getSubExpr();
+    else if (GenericSelectionExpr *GSE = dyn_cast<GenericSelectionExpr>(E))
----------------
rsmith wrote:
> I guess this is just for `UO_Extension`. Is it worth asserting that?
I don't think it's likely that anyone would ever trip the assertion, but maybe worthwhile just to document the meaning, sure.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58069/new/

https://reviews.llvm.org/D58069





More information about the cfe-commits mailing list