[PATCH] D58010: [CodeGen] Set construction vtable visibility after creating initializer
Roland McGrath via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Sat Feb 9 19:55:52 PST 2019
mcgrathr accepted this revision.
mcgrathr added a comment.
This revision is now accepted and ready to land.
lgtm with a comment (and perhaps an assertion).
Comment at: clang/lib/CodeGen/CGVTables.cpp:777
+ CGM.setGVProperties(VTable, RD);
Give it a comment pointing out the importance of doing this after createVTableInitializer rather than before.
If there's an easy way to add an "assert(is defined)" before setGVProperties to go with the comment, do that too.
CHANGES SINCE LAST ACTION
More information about the cfe-commits