[PATCH] D57874: [WebAssembly] Make thread-related options consistent
Sam Clegg via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Feb 8 16:17:59 PST 2019
sbc100 added inline comments.
Comment at: lib/Driver/ToolChains/WebAssembly.cpp:50
+ bool HasNoPthread =
+ !Pthread && DriverArgs.hasArg(clang::driver::options::OPT_no_pthread);
> Should this logic use `getLastArg` or perhaps `getLastArgNoClaim` to check only that the final requested configuration is consistent rather than checking all intermediate configurations?
Can you remove all the "clang::driver" namspace qualification here since there is a "using" above?
CHANGES SINCE LAST ACTION
More information about the cfe-commits