[PATCH] D57874: [WebAssembly] Make thread-related options consistent

Thomas Lively via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Feb 8 13:44:31 PST 2019

tlively added a comment.

In D57874#1390014 <https://reviews.llvm.org/D57874#1390014>, @sbc100 wrote:

> In D57874#1389981 <https://reviews.llvm.org/D57874#1389981>, @sunfish wrote:
> > > - `-matomics` means `-mthread-model posix`
> >
> > The others sound reasonable, though this one seems a little surprising -- a user might have -matomics enabled because they're targeting a VM that has atomics, but still not want to use -mthread-model posix because their code doesn't actually using threads.
> If you look at what "-mthread-model posix" actually means in the codebase it basically means "don't lower away atomics ops".
> Its only used by WebAssembly and ARMTargetMachine to select the `createLowerAtomicPass`.   Given that these are the only uses it seems like it should be removed or renamed.

FWIW, I plan to use the thread-model argument to determine what kind of initialization flags data segments should use as well. Will share a short doc detailing this soon.

  rC Clang



More information about the cfe-commits mailing list